Skip to content

Conversation

@71zenith
Copy link
Collaborator

Pull Request Template

Type of change

  • Bug fix
  • Feature
  • Documentation update

Description

ramble here

Checklist

  • any anime playing
  • bumped version

  • next, prev and replay work
  • -c history and continue work
  • -d downloads work
  • -s syncplay works
  • -q quality works
  • -v vlc works
  • -e select episode works
  • -S select index works
  • -r range selection works
  • --skip ani-skip works
  • --skip-title ani-skip title argument works
  • --no-detach no detach works
  • --dub and regular (sub) mode both work
  • all providers return links (not necessarily on a single anime, use debug mode to confirm)

  • -h help info is up to date
  • Readme is up to date
  • Man page is up to date

Additional Testcases

  • The safe bet: One Piece
  • Episode 0: Saenai Heroine no Sodatekata ♭
  • Unicode: Saenai Heroine no Sodatekata ♭
  • Non-whole episodes: Tensei shitara slime datta ken (ep. 24.5, ep. 24.9)

@71zenith 71zenith requested a review from Derisis13 as a code owner February 23, 2025 19:03
@Derisis13
Copy link
Collaborator

What if we tested this really thoroughly then made it 4.10?

@71zenith
Copy link
Collaborator Author

I'm okay with that but I'd rather have the final patch before 4.10 be the one fixing the provider quality situation

@port19x
Copy link
Collaborator

port19x commented Feb 26, 2025

is this related to #1466 ?

@71zenith
Copy link
Collaborator Author

yes, my bad I should have linked it

@71zenith 71zenith linked an issue Feb 26, 2025 that may be closed by this pull request
@port19x
Copy link
Collaborator

port19x commented Feb 26, 2025

thanks

Copy link
Collaborator

@port19x port19x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can still reproduce the issue with this branch

@71zenith
Copy link
Collaborator Author

welp, which episode ranges?

@port19x
Copy link
Collaborator

port19x commented Feb 26, 2025

One Piece, tried episodes 1 & 2. This results in infinite range on both versions (I quit after 10 eps)

@port19x port19x merged commit e48843b into master Feb 26, 2025
9 checks passed
@71zenith 71zenith deleted the fix-range branch March 12, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

multi-selection is broken for single digit episodes

4 participants