fix: log debug outputs to stderr #1548
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Send informations like "Checking dependencies", "Playing Episode n", etc to stderr so it can be routed easily to /dev/null if needed. Clear screen using tput clear only if player_function is not dump or download so debug/download statuses are preserved.
Collaborator
|
I like the tput part, not sure about the stderr... Is it common to print info messages to stderr? |
Author
|
The main purpose of this patch is:
|
Author
|
Hmm. Maybe routing info messages to stderr is not a good idea. Shall i revert that? |
Collaborator
|
I mean I guess you don't really violate any rules by writing to stderr, but I don't see a point either, as for debugging we advise Closing this because I don't see any point |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Send informations like "Checking dependencies", "Playing Episode n", etc
to stderr so it can be routed easily to /dev/null if needed.
Clear screen using tput clear only if player_function is not dump or
download so debug/download statuses are preserved.