Mention asyncio_default_fixture_loop_scope in v0.24 changelog
#1014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This config option is arguably a new API surface, and it took me a fair bit of git archaeology to figure out from which version on I can use this config option. This entry might save some users some time in the future :)
robsdedude
requested review from
Tinche,
asvetlov and
seifertm
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1014 +/- ##
=======================================
Coverage 90.83% 90.83%
=======================================
Files 2 2
Lines 513 513
Branches 66 66
=======================================
Hits 466 466
Misses 28 28
Partials 19 19 ☔ View full report in Codecov by Sentry. |
seifertm
approved these changes
Dec 12, 2024
Contributor
seifertm
left a comment
seifertm
left a comment
There was a problem hiding this comment.
Thanks for the PR.
We should probably have done a better job advertising the new configuration option. Adding it to the changelog seems fair.
seifertm
changed the title
asyncio_default_fixture_loop_scopeasyncio_default_fixture_loop_scope in v0.24 changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This config option is arguably a new API surface, and it took me a fair bit of git archaeology to figure out from which version on I can use this config option.
This entry might save some users some time in the future :)