Skip to content

fixtures: avoid unnecessary closure #1185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025
Merged

fixtures: avoid unnecessary closure #1185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions pytest_django/fixtures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,17 @@ def tearDownClass(cls) -> None:
PytestDjangoTestCase.doClassCleanups()


def _django_db_signature(
transaction: bool = False,
reset_sequences: bool = False,
databases: _DjangoDbDatabases = None,
serialized_rollback: bool = False,
available_apps: _DjangoDbAvailableApps = None,
) -> _DjangoDb:
"""The signature of the django_db marker. Used by validate_django_db."""
return transaction, reset_sequences, databases, serialized_rollback, available_apps


def validate_django_db(marker: pytest.Mark) -> _DjangoDb:
"""Validate the django_db marker.

Expand All @@ -267,17 +278,7 @@ def validate_django_db(marker: pytest.Mark) -> _DjangoDb:
Sequence reset, serialized_rollback, and available_apps are only allowed
when combined with transaction.
"""

def apifun(
transaction: bool = False,
reset_sequences: bool = False,
databases: _DjangoDbDatabases = None,
serialized_rollback: bool = False,
available_apps: _DjangoDbAvailableApps = None,
) -> _DjangoDb:
return transaction, reset_sequences, databases, serialized_rollback, available_apps

return apifun(*marker.args, **marker.kwargs)
return _django_db_signature(*marker.args, **marker.kwargs)


def _disable_migrations() -> None:
Expand Down