Skip to content

Conversation

@youtux
Copy link
Contributor

@youtux youtux commented Sep 16, 2025

No description provided.

@youtux youtux requested a review from Copilot September 16, 2025 19:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames the fixtures parameter to dependencies across the pytest-factoryboy fixture generation functions. This change improves clarity by using a more descriptive name that better communicates the parameter's purpose as fixture dependencies that won't be passed to the function.

  • Renamed fixtures parameter to dependencies in create_fixture and create_fixture_with_related functions
  • Updated all function calls to use the new parameter name
  • Updated docstring documentation to reflect the parameter name change

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/pytest_factoryboy/fixturegen.py Updated create_fixture function signature, docstring, and implementation to use dependencies instead of fixtures
src/pytest_factoryboy/fixture.py Updated create_fixture_with_related function signature and all calls to use dependencies parameter

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Sep 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.85%. Comparing base (059bb0c) to head (95ef46b).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #252   +/-   ##
=======================================
  Coverage   97.85%   97.85%           
=======================================
  Files          16       16           
  Lines         886      886           
  Branches       54       54           
=======================================
  Hits          867      867           
  Misses          8        8           
  Partials       11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@youtux youtux enabled auto-merge September 16, 2025 20:43
@youtux youtux merged commit fd22340 into master Sep 16, 2025
20 checks passed
@youtux youtux deleted the rename-param branch September 16, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants