Skip to content
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 66 additions & 0 deletions src/pytest_html/nextgen.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
import json
from typing import Any

This comment was marked as outdated.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened an issue to track typing (#434)

I also added mypy to our linting target and began work on typing the project in #435

from typing import Dict

import pytest


class NextGenReport:
def __init__(self, config, data_file):
self._config = config
self._data_file = data_file

self._title = "Next Gen Report"
self._data = {
"title": self._title,
"collectedItems": 0,
"environment": {},
"tests": [],
}

self._data_file.parent.mkdir(parents=True, exist_ok=True)

def _write(self):
try:
data = json.dumps(self._data)
except TypeError:
data = cleanup_unserializable(self._data)
data = json.dumps(data)

with self._data_file.open("w", buffering=1, encoding="UTF-8") as f:
f.write("const jsonData = ")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we combine these f.write calls on an f string line f"const jsonData = {data}\n"?

f.write(data)
f.write("\n")

@pytest.hookimpl(trylast=True)
def pytest_sessionstart(self, session):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't all the self._write calls overwrite self._data_file?

config = session.config
if hasattr(config, "_metadata") and config._metadata:
metadata = config._metadata
self._data["environment"] = metadata
self._write()

@pytest.hookimpl(trylast=True)
def pytest_collection_finish(self, session):
self._data["collectedItems"] = len(session.items)
self._write()

@pytest.hookimpl(trylast=True)
def pytest_runtest_logreport(self, report):
data = self._config.hook.pytest_report_to_serializable(
config=self._config, report=report
)
self._data["tests"].append(data)
self._write()


def cleanup_unserializable(d: Dict[str, Any]) -> Dict[str, Any]:
"""Return new dict with entries that are not json serializable by their str()."""
result = {}
for k, v in d.items():
try:
json.dumps({k: v})
except TypeError:
v = str(v)
result[k] = v
return result
9 changes: 9 additions & 0 deletions src/pytest_html/plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,14 @@

import pytest
from _pytest.logging import _remove_ansi_escape_sequences
from _pytest.pathlib import Path
from py.xml import html
from py.xml import raw

from . import __pypi_url__
from . import __version__
from . import extras
from . import nextgen


@lru_cache()
Expand Down Expand Up @@ -101,7 +103,9 @@ def pytest_configure(config):
if not hasattr(config, "workerinput"):
# prevent opening htmlpath on worker nodes (xdist)
config._html = HTMLReport(htmlpath, config)
config._next_gen = nextgen.NextGenReport(config, Path("nextgendata.js"))
config.pluginmanager.register(config._html)
config.pluginmanager.register(config._next_gen)


def pytest_unconfigure(config):
Expand All @@ -110,6 +114,11 @@ def pytest_unconfigure(config):
del config._html
config.pluginmanager.unregister(html)

next_gen = getattr(config, "_next_gen", None)
if next_gen:
del config._next_gen
config.pluginmanager.unregister(next_gen)


@pytest.hookimpl(tryfirst=True, hookwrapper=True)
def pytest_runtest_makereport(item, call):
Expand Down