Drop support for EOL Python 3.6 #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diazona
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
Makes sense to me, thanks!
As far as 3.7 and 3.8: my approach has been that I won't make any special effort to develop in a way that's compatible with an old version of Python, but as long as the package does in fact appear to be compatible (i.e. CI jobs on that version run and pass), I'll keep the metadata to mark it as such. Given that, I'd prefer not to drop the 3.7 and 3.8 markers yet. So I'm on board with this PR as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Actions has deprecated the
ubuntu-20.04runner, and it'll be fully unsupported by 2025-04-01: actions/runner-images#11101I spotted this repo is still using to test Python 3.6, which has been end-of-life since 2021, so it's definitely time to drop support:
https://devguide.python.org/versions/
Python 3.7 and 3.8 are also EOL, and I recommend dropping them too. I haven't done so in this PR, but I'm happy to include it here or in a new PR if you like.