Drop Python 3.5 support #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our CI jobs have stopped working with Python 3.5 since pip is no longer able to upgrade itself. Perhaps there was a recent change in PyPI's SSL certificate that makes it unable to be verified on Python 3.5, at least within GitHub Actions. Since Python 3.5 is long past EOL, we don't think it's worth putting in any work to get that job working again, so this commit drops it from the CI test configuration.
This officially drops Python 3.5 support from the project.
Our SMTP Server implementation normally calls asyncio.base_events.Server.is_serving() to test whether the server is active, but that method only exists in Python 3.6 and up. For Python 3.5 it had to fall back to asyncio.base_events.BaseEventLoop.is_running(). Now that we no longer support Python 3.5, that fallback is no longer necessary, so I'm removing it.
coordt
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our CI jobs have stopped working with Python 3.5 since pip is no longer able to upgrade itself. Perhaps there was a recent change in PyPI's SSL certificate that makes it unable to be verified on Python 3.5, at least within GitHub Actions. Since Python 3.5 is long past EOL, we don't think it's worth putting in any work to get that job working again, so this pull request drops support for Python 3.5.
The package may still work with Python 3.5, and anyone who wants to try it is welcome to give it a go, but it's no longer officially supported and we are not putting in any effort to keep it working on 3.5 in future versions.