Document ordering of test modules #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mrbean-bremen
commented
May 2, 2025
mrbean-bremen
commented
- see [Label] Allow specifying full directories/files as order targets #51
Member
Author
|
@jenstroeger - can you please have a look? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #176 +/- ##
=======================================
Coverage 98.50% 98.50%
=======================================
Files 5 5
Lines 601 601
Branches 131 131
=======================================
Hits 592 592
Misses 2 2
Partials 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jenstroeger
approved these changes
May 2, 2025
jenstroeger
left a comment
jenstroeger
left a comment
There was a problem hiding this comment.
This looks great, good to see this documented 👍🏼
Can you also mention what happens to modules without marker mixed with modules with order marker? And I suspect -1 still puts a module at the end? Other than that let me just approve…
mrbean-bremen
force-pushed
the
module-order
branch
from
a7f9df2 to
d0235e7
Compare
jenstroeger
approved these changes
May 3, 2025
Member
Author
|
@jenstroeger - Thanks for the review! I'll leave the PR open for a bit in case you want to have a final look. |
|
All good, thank you 🤓 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.