-
Notifications
You must be signed in to change notification settings - Fork 20
Convert to hatch and pyproject.toml #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Let's completely switch over something is getting confused |
Does anybody know of a tool that can do that automatically? Not looking forward to it manually. 😁 |
imho this is fine to go to hatch :) |
@nicoddemus i can do it sometime tommorow if you dont get to it today |
It's also possible to do a migration to setup.cfg first, then use an ini to toml conversion, it's two steps but historically it make sense. (I can do it too if you want) |
@Pierre-Sassoulas why do 2 step when 1 step tools are avaliable? |
Thanks @RonnyPfannschmidt for the tip! Hmmm still failing... weird, it worked just fine for me locally:
I used |
I suspect cache poisoning |
Created another job which builds the package manually and it passes: https://github.com/pytest-dev/pytest-reportlog/actions/runs/16763542482/job/47464059761?pr=78 Seems related to |
💥 it was just a matter of updating |
ddafcad
to
c34afb5
Compare
* Converted setup.py to pyproject.toml: used `hatch new --init` and manually added `hatch-vcs` configuration. * Updated `hynek/build-and-inspect-python-package` -- in the end this was the original problem. * Added `dependabot.yml` configuration to avoid this problem in the future. Follow up to #77.
c34afb5
to
73d5d5c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It permits to not have to learn another tool if like me you already did multiple setup.cfg migration before :) (and hatch need some cleanup to reinstate something simple and stupid like setuptools at the end). Or we can keep hatch but the python packaging ecosystem would benefit from less choice imo.
@@ -0,0 +1,54 @@ | |||
[build-system] | |||
requires = ["hatchling", "hatch-vcs"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have to keep hatch it was only for the migration, right ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually keeping it us nice for pure python its much nicer than setuptools
And its way easier to maintain
Thanks folks! |
Converted
setup.py
topyproject.toml
: usedhatch new --init
and manually addedhatch-vcs
configuration.Updated
hynek/build-and-inspect-python-package
-- in the end this was the original problem.Added
dependabot.yml
configuration to avoid this problem in the future.Follow up to #77.