fixtures: fix crash when parametrize(scope="package") is used without a Package
#11256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed this while reviewing @sadra-barikbin's changes in #11220 (unfortunately it will create a minor conflict). Previously this code was not covered, which I noticed in the coverage report of #11138. |
…ut a Package There as handling for `scope="class"` without a class, but not for `scope="package"` without a package. It would fail the assert.
bluetech
force-pushed
the
scope-pkg-crash
branch
from
bf62cbb to
71e627a
Compare
nicoddemus
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is handling for
scope="class"without a class, but not forscope="package"without a package. It would fail the assert.