hookspec: deprecate hookimpls requesting py.path parameters #12227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonnyPfannschmidt
approved these changes
Apr 19, 2024
Member
RonnyPfannschmidt
left a comment
RonnyPfannschmidt
left a comment
There was a problem hiding this comment.
lovely, lets put this into draft until we can depend on the new minimal pluggy version
nicoddemus
approved these changes
Apr 19, 2024
bluetech
force-pushed
the
deprecate-legacy-path-impls
branch
from
dca7eb3 to
5688acd
Compare
RonnyPfannschmidt
approved these changes
Apr 21, 2024
bluetech
force-pushed
the
deprecate-legacy-path-impls
branch
2 times, most recently
from
7d6fe29 to
0ce6ca3
Compare
bluetech
force-pushed
the
deprecate-legacy-path-impls
branch
from
0ce6ca3 to
58136c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the deprecation that we missed in 7.x (see #12069) so that we can remove them again in 9.x.
Uses new feature of pluggy to deprecate parameters,
not yet mergedreleased in pluggy 1.5: pytest-dev/pluggy#495