Fixed color test when TERM=dumb #12244
Merged
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReillyBrogan
force-pushed
the
fix-color-test
branch
from
cb2c1d2 to
7eebd11
Compare
The-Compiler
requested changes
Apr 26, 2024
There was a problem hiding this comment.
I don't think the test needs to be skipped if NO_COLOR is set, as monkeypatch in the test already takes care of that.
In the same vein, couldn't the test just set TERM to a known value instead of skipping the test, to make it work no matter what the "outside" TERM is?
Dumb terminals are incapable of handling color, so this test would fail when ran in such an environment.
bluetech
force-pushed
the
fix-color-test
branch
from
f380419 to
df4af6a
Compare
psf-chronographer
bot
added
the
bot:chronographer:provided
|
I applied @The-Compiler suggestion and confirmed that it works. Will merge once CI passes, thanks! |
bluetech
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dumb terminals are incapable of handling color, so this test would fail when ran in such an environment. We encountered this on the Solus build infrastructure which uses such a headless terminal.