-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Add --force-short-summary option and extend sequence printing with -vv #13061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@nicoddemus @bluetech @RonnyPfannschmidt @The-Compiler |
RonnyPfannschmidt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems useful in the short term
I hope we can eventually fold it into the idea of verbosity categories that currently is in limbo
| else: | ||
| if running_on_ci() or config.option.verbose >= 2: | ||
| if ( | ||
| running_on_ci() or config.option.verbose >= 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is getting tricky
But I'm torn about whether there should be a helper
|
Appreciate the review! Happy to help out if/when the verbosity categories come out of limbo; I got a decent amount of familiarity with the current systems putting this PR together, so would be glad to put that to use. Thanks! |
This option allows the users to always see the "short test summary" section regardless of the verbosity level. Fix pytest-dev#12713
10f84e1 to
d471aef
Compare
nicoddemus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kenny-y-dev for the PR!
Took the liberty of splitting the PR into two commits, so can backport the bugfix. 👍
|
Backport: #13163 |
Closes #12713.
The fix for issue #11777 removed any output shortening in the test summary output when
-vvis used, leading to potentially long/redundant summary messages. The issue in #11777 is also now fully fixed, as series were still condensed in output even with full verbosity.Since the removal of the summary shortening has been in place for a while, the addition of a new runtime option seemed to be the best way to address #12713 without changes to existing functionality.
--force-short-summarywas added to always show a shortened summary message regardless of the verbosity setting. Additionally, when using-vv,saferepr_unlimitedis now called to fully resolve #11777.