-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
officially support python 3.14 #13440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 10 commits
afb2205
765376f
d04caf7
938239a
8f93112
a4a63f5
73ec95e
bd31527
98a538e
024c2b8
96700eb
893d43b
3396bc3
f8767c3
3998c06
25682a0
d1a82c0
98a4d88
552df0f
cf24e6b
f37b7a1
35e2715
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| support Python 3.14 | ||
graingert marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1373,6 +1373,7 @@ def do_quit(self, *args): | |
| result.stdout.fnmatch_lines(["*runcall_called*", "* 1 passed in *"]) | ||
|
|
||
|
|
||
| @pytest.mark.xfail(sys.version_info >= (3, 14), reason="I don't know why this fails") | ||
|
||
| def test_raises_bdbquit_with_eoferror(pytester: Pytester) -> None: | ||
| """It is not guaranteed that DontReadFromInput's read is called.""" | ||
| p1 = pytester.makepyfile( | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for
check-latestto work thematrix.pythonentries should be named3.14-devThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not always have
check-latest: true?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/actions/setup-python/blob/main/docs/advanced-usage.md#check-latest-version
apparently performance & stability, though kind of seems more reliable to have it set to true to ensure you don't randomly get an old cached version. No clue what the performance hit would be
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer not to use
-devbecause then you have to remember to remove it for final release. I preferallow-prereleasesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems fine 👍