Skip to content

Fix gh pr new command #13639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix gh pr new command #13639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ddec09
Fix deprecated 'gh pr new' command to 'gh pr create'
popododo0720 Aug 8, 2025
785bac3
Add changelog entry and update AUTHORS for gh pr command fix
popododo0720 Aug 8, 2025
c390eee
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,7 @@ Kevin Hierro Carrasco
Kevin J. Foley
Kian Eliasi
Kian-Meng Ang
Kim Soo
Kodi B. Arfer
Kojo Idrissa
Kostis Anagnostopoulos
Expand Down
2 changes: 2 additions & 0 deletions changelog/13638.bugfix.rst
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be contrib instead of bugfix as it's not a bugfix relevant for users of pytest.

Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fixed deprecated ``gh pr new`` command in :file:`scripts/prepare-release-pr.py`.
The script now uses ``gh pr create`` which is compatible with GitHub CLI v2.0+.
Comment on lines +1 to +2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Fixed deprecated ``gh pr new`` command in :file:`scripts/prepare-release-pr.py`.
The script now uses ``gh pr create`` which is compatible with GitHub CLI v2.0+.
Fixed deprecated :command:`gh pr new` command in :file:`scripts/prepare-release-pr.py`.
The script now uses :command:`gh pr create` which is compatible with GitHub CLI v2.0+.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got curious because those were new to me, but it doesn't seem :command: or :file: have any effect other than format the text as code:

image

I don't mind leaving it there if you prefer, but I mention in case it was expected to produce different results.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Furo needs to learn to style them. But markup-wise, they are nice to have.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pradyunsg/furo#890

2 changes: 1 addition & 1 deletion scripts/prepare-release-pr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ def prepare_release_pr(base_branch: str, is_major: bool, prerelease: str) -> Non
[
"gh",
"pr",
"new",
"create",
f"--base={base_branch}",
f"--head={release_branch}",
f"--title=Release {version}",
Expand Down
Loading