fix(testing): pytest.approx
correctly take account Mapping keys order to compare them
#13815
+15
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR fixes an issue with
pytest.approx
where the error message incorrectly reported all elements as mismatched when comparing mappings with different key orders, even when only some values differed.The original code paired values by position rather than by key. This caused incorrect mismatch reporting when dictionary keys were in different orders.
This closes #12444.
Checklist
changelog
folder, named<ISSUE NUMBER>.<TYPE>.rst
.