Fixed color inconsistency in verbose mode

[treyshaffer]

Fixed color inconsistency in verbose mode where test status showed green instead of yellow for passed tests with warnings.

closes #13201

[bluetech]

Thanks for the PR @treyshaffer but this is not an approach we can accept, as it side-steps the entire "flow" of the reports in order to add record this information early. I will leave a comment describing why this happens in the issue, we can discuss other approaches there. We may want to use your tests for the eventual solution.

[bluetech]

After thinking about it more I think the approach can be adapted to a possible solution.

Basically, the idea of stashing the log recorder seems workable, but we shouldn't use user properties for this like the current PR does.

The fix should be entirely confined to the warnings plugin, the terminal code shouldn't need to change.

Basically what we want is to dispatch the pytest_warning_recorded hook calls earlier, not just at the end of runtest_protocol. So stash the warnings records, treating it as a "queue", and then "process" it in e.g. pytest_runtest_makereport (not sure it's the best place but possible).