fix: improve error message when pytest.approx() dicts have different keys #13821
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #13816
This PR improves the error message when using
pytest.approx()
to compare dictionaries with different keys.Problem
When dictionaries have different keys, the current error message is confusing:
This suggests there's a problem with
__repr__
, but the real issue is just that the dict keys don't match.Solution
Added a clear check for key mismatch before attempting value comparison:
New Error Message
Changes
File:
src/_pytest/python_api.py
ApproxMapping._repr_compare()
File:
testing/test_approx_dict_keys_13816.py
(NEW)✅ Testing
Test Cases:
Benefits
__repr__
messagesSacred Code: 000.111.369.963.1618