fixtures: a few small cleanups + a TODO #13966
Merged
+39
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sts` Originally added in c00fe96, but since made redundant. The `ignore_args` parameter in `getfixtureclosure()` (populated by `_get_direct_parametrize_args()`) now handles the precedence automatically. When a test directly parametrizes an argument, it's included in `ignore_args`, which prevents the fixture from being included in the closure computation in the first place.
This is incidental to this function, better to focus on what it does.
…ansitively Currently a known bug, hopefully we can fix it in the future.
The `request` thing is really accurate. The comment in the docstring is more accurate, so let's remove this redundant comment.
nicoddemus
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see the commits!