Skip to content

Conversation

cprussin
Copy link
Contributor

To be quite honest, I'm not sure if this is safe or what it might break (or why this was ever done in the first place). However, having SSR disabled is causing some docs pages to have terrible performance and people are complaining.

I did some testing with this and I didn't see any issues. At this point I believe the best path forward is to re-enable SSR and just fix forward if we find any issues I missed

To be quite honest, I'm not sure if this is safe or what it might break (or why
this was ever done in the first place).  However, having SSR disabled is causing
some docs pages to have terrible performance and people are complaining.

I did some testing with this and I didn't see any issues.  At this point I
believe the best path forward is to re-enable SSR and just fix forward if we
find any issues I missed
@cprussin cprussin requested a review from cctdaniel February 18, 2025 20:09
@vercel
Copy link

vercel bot commented Feb 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 8:12pm
documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 8:12pm

@cprussin
Copy link
Contributor Author

Closing this as it did not have the expected impact on performance

@cprussin cprussin closed this Feb 19, 2025
@cprussin cprussin deleted the cprussin/re-enable-ssr branch February 19, 2025 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant