-
Notifications
You must be signed in to change notification settings - Fork 38
chore(entropy) What's new #778
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| - abstracted away the information from `EntropyStructs.Request` to the `Revealed` event for easier consumption. | ||
| - added a `callbackFailed` boolean to indicate if the callback failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: prefer the present tense -- "abstracts away" and "adds a"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also instead of "abstracted away..." I'd say something like:
"Denormalizes fields from EntropyStructs.Request to a flat representation for easier consumption."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we wanna mention the reliability upgrades in this doc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was not sure about that. What do you think?
KemarTiti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* chore(entropy) What's new * update * requested changes
* chore(entropy) Dyamic Fee table * update * update * alias viem * use entropy sdk * requested changes * updated package.json * kill me * Update solana_mainnet.json (#779) * Update solana_mainnet.json ADD JUPSOL TO DOCS * Update solana_mainnet.json --------- Co-authored-by: Ali Behjati <[email protected]> * chore(entropy) What's new (#778) * chore(entropy) What's new * update * requested changes * updated package.json * requested changes * prettier --------- Co-authored-by: KemarTiti <[email protected]> Co-authored-by: Ali Behjati <[email protected]>
Description
Type of Change
Areas Affected
Checklist
pre-commit run --all-filesto check for linting errorsRelated Issues
Closes #
Additional Notes
Contributor Information
Screenshots