chore(pricefeeds) Improve Landing page #812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
alexcambose
reviewed
Aug 25, 2025
Comment on lines
1
to
10
| import React from "react"; | ||
|
|
||
| export function BarChartIcon() { | ||
| return ( | ||
| <svg className="w-5 h-5" fill="currentColor" viewBox="0 0 20 20"> | ||
| <path d="M2 11a1 1 0 011-1h2a1 1 0 011 1v5a1 1 0 01-1 1H3a1 1 0 01-1-1v-5zM8 7a1 1 0 011-1h2a1 1 0 011 1v9a1 1 0 01-1 1H9a1 1 0 01-1-1V7zM14 4a1 1 0 011-1h2a1 1 0 011 1v12a1 1 0 01-1 1h-2a1 1 0 01-1-1V4z" /> | ||
| </svg> | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
I would strongly recommend using an icon package like https://github.com/phosphor-icons/homepage so we don't have to paste SVG code here.
Comment on lines
+31
to
+40
| <div | ||
| className={`bg-white dark:bg-gray-800 rounded-lg border border-gray-200 dark:border-gray-700 p-6 shadow-sm hover:shadow-md transition-shadow flex flex-col h-full ${className}`} | ||
| > | ||
| {/* Header with badge and icon */} | ||
| <div className="flex items-center gap-3 mb-4"> | ||
| <div | ||
| className={`${badgeColor} text-white text-xs font-semibold px-3 py-1.5 rounded-full`} | ||
| > | ||
| {badge} | ||
| </div> |
There was a problem hiding this comment.
Generally using a package like https://www.npmjs.com/package/clsx is a better solution than appending class names as strings
There was a problem hiding this comment.
I agree. This is just a temp fix to improve navigation.
alexcambose
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Areas Affected
Checklist
pre-commit run --all-filesto check for linting errorsRelated Issues
Closes #
Additional Notes
Contributor Information
Screenshots