Publish a Minimal Container Image to ECR Public #148
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in addition to the existing full-size image
|
Thanks a lot for your contribution. I think the existing one is only useful for testing and we can stop publishing it. i created #149 to actually replace the main one with the minimal one and bumped the version. |
ali-behjati
added a commit
that referenced
this pull request
Jan 9, 2025
* refactor(docker): use minimal docker for image publish * update readme to add dockerfile taken from #148 * add skipped dockerfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the current full-size image in a production deployment isn't really feasible, but the minimal container image already in this repo already has everything required. We're looking to move our Pyth Publisher into Kubernetes and this would make that change much easier.
To give you some idea of the size difference:
It'd probably also be worthwhile to upload a basic
Aboutand Icon to ECR Public to help users know they've found the correct page. Some guidance on doing that can be found on https://docs.aws.amazon.com/AmazonECR/latest/public/public-repository-catalog-data.html.