-
Notifications
You must be signed in to change notification settings - Fork 19
Reduce memory usage, faster copies and other small improvements #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@ali-bahjati what are you using for formatting and clippy so I can use the same? |
@rodoufu if you install pre-commit and run it it should fix it. I can handle it regardless myself. |
Thanks @ali-bahjati , I totally missed that file in the project. $ pre-commit --version && pre-commit run --all-files && echo $?
pre-commit 4.1.0
Trim Trailing Whitespace.................................................Passed
Fix End of Files.........................................................Passed
Check for added large files..............................................Passed
rustfmt..................................................................Failed
- hook id: cargo-fmt-nightly
- files were modified by this hook
Integration Test Artifact Checksums......................................Passed Now everything looks green. $ pre-commit --version && pre-commit run --all-files && echo $?
pre-commit 4.1.0
Trim Trailing Whitespace.................................................Passed
Fix End of Files.........................................................Passed
Check for added large files..............................................Passed
rustfmt..................................................................Passed
Integration Test Artifact Checksums......................................Passed
0 |
Arc<PriceEntry>
andArc<ProductEntry>
inUpdateProductAccountUpdate
andUpdate::PriceAccountUpdate
to decrease the size difference between the variants.Arc<PriceEntry>
andArc<ProductEntry>
in maps to reduce clone time by only cloning the referenceSmolStr
clone
onCopy