Skip to content

Reduce memory usage, faster copies and other small improvements #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 5, 2025

Conversation

rodoufu
Copy link
Contributor

@rodoufu rodoufu commented Feb 27, 2025

  • Using Arc<PriceEntry> and Arc<ProductEntry> in UpdateProductAccountUpdate and Update::PriceAccountUpdate to decrease the size difference between the variants.
  • Using Arc<PriceEntry> and Arc<ProductEntry> in maps to reduce clone time by only cloning the reference
  • Replacing imutable strings by SmolStr
  • Remove unnecessary clone on Copy
  • Fix audit issue:
Crate:     rustls                                                                                               
Version:   0.21.10                                                                                              
Title:     `rustls::ConnectionCommon::complete_io` could fall into an infinite loop based on network input      
Date:      2024-04-19                                                                                           
ID:        RUSTSEC-2024-0336                                                                                    
URL:       https://rustsec.org/advisories/RUSTSEC-2024-0336                                                     
Severity:  7.5 (high)                                                                                           
Solution:  Upgrade to >=0.23.5 OR >=0.22.4, <0.23.0 OR >=0.21.11, <0.22.0

@rodoufu
Copy link
Contributor Author

rodoufu commented Mar 3, 2025

@ali-bahjati what are you using for formatting and clippy so I can use the same?

@ali-behjati
Copy link
Collaborator

@rodoufu if you install pre-commit and run it it should fix it. I can handle it regardless myself.

@rodoufu
Copy link
Contributor Author

rodoufu commented Mar 5, 2025

@rodoufu if you install pre-commit and run it it should fix it. I can handle it regardless myself.

Thanks @ali-bahjati , I totally missed that file in the project.
I have just fixed the formatting issues:

$ pre-commit --version && pre-commit run --all-files && echo $?
pre-commit 4.1.0

Trim Trailing Whitespace.................................................Passed
Fix End of Files.........................................................Passed
Check for added large files..............................................Passed
rustfmt..................................................................Failed
- hook id: cargo-fmt-nightly
- files were modified by this hook
Integration Test Artifact Checksums......................................Passed

Now everything looks green.

$ pre-commit --version && pre-commit run --all-files && echo $?
pre-commit 4.1.0

Trim Trailing Whitespace.................................................Passed
Fix End of Files.........................................................Passed
Check for added large files..............................................Passed
rustfmt..................................................................Passed
Integration Test Artifact Checksums......................................Passed

0

@ali-behjati ali-behjati merged commit a9d77e0 into pyth-network:main Mar 5, 2025
2 checks passed
@rodoufu rodoufu deleted the smallImps branch March 5, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants