Skip to content

chore(staking): remove quality ranking #1970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

chore(staking): remove quality ranking #1970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions apps/staking/src/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ type Data = {
poolUtilization: bigint;
poolUtilizationDelta: bigint;
numFeeds: number;
qualityRanking: number;
apyHistory: { date: Date; apy: number }[];
positions?:
| {
Expand Down Expand Up @@ -304,7 +303,6 @@ const loadPublisherData = async (
poolUtilization: publisher.totalDelegation,
poolUtilizationDelta: publisher.totalDelegationDelta,
publicKey: publisher.pubkey,
qualityRanking: publisherRanking?.rank ?? 0,
selfStake: publisher.selfDelegation,
selfStakeDelta: publisher.selfDelegationDelta,
stakeAccount: publisher.stakeAccount ?? undefined,
Expand Down
20 changes: 0 additions & 20 deletions apps/staking/src/components/GeneralFaq/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,26 +206,6 @@ export const GeneralFaq = (
</>
),
},
{
question: "How are publisher quality rankings calculated?",
answer: (
<>
<p>
Quality rankings are calculated based on a publisher’s price
deviation, uptime, and price staleness. You can learn more about
quality ranking calculations{" "}
<Link
href="https://docs.pyth.network/home/oracle-integrity-staking/publisher-quality-ranking"
className="underline"
target="_blank"
>
here
</Link>
.
</p>
</>
),
},
{
question: "Can the Pyth DAO change the parameters of OIS?",
answer:
Expand Down
2 changes: 1 addition & 1 deletion apps/staking/src/components/NoWalletHome/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ export const NoWalletHome = () => {
},
{
title: "Select Publishers",
body: "Choose which data publishers to support by staking your tokens towards them to help secure the oracle. You can sort publishers by their stake pool details, quality ranking, and more.",
body: "Choose which data publishers to support by staking your tokens towards them to help secure the oracle. You can sort publishers by their stake pool details, number of feeds, and more.",
icon: SelectPublishers,
},
{
Expand Down
42 changes: 0 additions & 42 deletions apps/staking/src/components/OracleIntegrityStaking/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,6 @@ const SelfStaking = ({
<PublisherTableHeader>Estimated next APY</PublisherTableHeader>
<PublisherTableHeader>Historical APY</PublisherTableHeader>
<PublisherTableHeader>Number of feeds</PublisherTableHeader>
<PublisherTableHeader>Quality ranking</PublisherTableHeader>
<PublisherTableHeader />
</tr>
</thead>
Expand Down Expand Up @@ -714,8 +713,6 @@ const PublisherList = ({
SortOption.SelfStakeAscending,
SortOption.NumberOfFeedsDescending,
SortOption.NumberOfFeedsAscending,
SortOption.QualityRankingDescending,
SortOption.QualityRankingAscending,
].map((id) => ({ id }))}
>
{({ id }) => (
Expand Down Expand Up @@ -804,14 +801,6 @@ const PublisherList = ({
>
Number of feeds
</SortablePublisherTableHeader>
<SortablePublisherTableHeader
asc={SortOption.QualityRankingAscending}
desc={SortOption.QualityRankingDescending}
sort={sort}
setSort={updateSort}
>
Quality ranking
</SortablePublisherTableHeader>
<PublisherTableHeader className="pr-4 sm:pr-10" />
</tr>
</thead>
Expand Down Expand Up @@ -985,19 +974,6 @@ const doSort = (
return sort === SortOption.RemainingPoolDescending ? -1 * value : value;
}
}
case SortOption.QualityRankingDescending:
case SortOption.QualityRankingAscending: {
if (a.qualityRanking === 0 && b.qualityRanking === 0) {
return 0;
} else if (a.qualityRanking === 0) {
return 1;
} else if (b.qualityRanking === 0) {
return -1;
} else {
const value = Number(a.qualityRanking - b.qualityRanking);
return sort === SortOption.QualityRankingAscending ? -1 * value : value;
}
}
case SortOption.SelfStakeAscending: {
return Number(a.selfStake - b.selfStake);
}
Expand Down Expand Up @@ -1075,7 +1051,6 @@ type PublisherProps = {
poolUtilization: bigint;
poolUtilizationDelta: bigint;
numFeeds: number;
qualityRanking: number;
apyHistory: { date: Date; apy: number }[];
positions?:
| {
Expand Down Expand Up @@ -1220,12 +1195,6 @@ const Publisher = ({
<dt className="font-semibold">Number of feeds:</dt>
<dd>{publisher.numFeeds}</dd>
</div>
<div className="flex flex-row items-center gap-2">
<dt className="font-semibold">Quality ranking:</dt>
<dd>
{publisher.qualityRanking === 0 ? "-" : publisher.qualityRanking}
</dd>
</div>
</dl>
</div>
{isSelf && (
Expand Down Expand Up @@ -1283,9 +1252,6 @@ const Publisher = ({
<PublisherTableCell className="text-center">
{publisher.numFeeds}
</PublisherTableCell>
<PublisherTableCell className="text-center">
{publisher.qualityRanking === 0 ? "-" : publisher.qualityRanking}
</PublisherTableCell>
<PublisherTableCell
className={clsx("text-right", { "pr-4 sm:pr-10": !isSelf })}
>
Expand Down Expand Up @@ -1650,8 +1616,6 @@ enum SortOption {
SelfStakeAscending,
NumberOfFeedsDescending,
NumberOfFeedsAscending,
QualityRankingDescending,
QualityRankingAscending,
}

const getSortName = (sortOption: SortOption) => {
Expand Down Expand Up @@ -1686,12 +1650,6 @@ const getSortName = (sortOption: SortOption) => {
case SortOption.NumberOfFeedsAscending: {
return "Least feeds";
}
case SortOption.QualityRankingDescending: {
return "Best quality ranking";
}
case SortOption.QualityRankingAscending: {
return "Worst quality ranking";
}
}
};

Expand Down
11 changes: 5 additions & 6 deletions apps/staking/src/components/OracleIntegrityStakingGuide/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,8 @@ export const OracleIntegrityStakingGuide = (
<>
<p>
You can sort and evaluate publishers based on metrics such as
their stake pool composition, number of feeds supported,
quality ranking, and more.
their stake pool composition, number of feeds supported, and
more.
</p>

<p>
Expand All @@ -201,10 +201,9 @@ export const OracleIntegrityStakingGuide = (
description: (
<p>
Oracle Integrity Staking incentivizes publishers to deliver
high-quality data, which is measured by a quality ranking
system. This ranking is based on three key factors: Uptime,
Price Deviation, and Price Staleness. Stakers can use these
rankings to help ensure the security of the price oracle.
high-quality data. Stakers can use the information on the
staking dashboard to help ensure the security of the price
oracle.
</p>
),
image: publisherQuality,
Expand Down
Loading