fix: join llc before delegating #1978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
guibescos
commented
Sep 27, 2024
| isWritable: false, | ||
| isSigner: false, | ||
| }, | ||
| ] |
There was a problem hiding this comment.
my formatter decided to do some stuff
There was a problem hiding this comment.
Does pnpm fix allow this?
| .instruction(); | ||
| } | ||
|
|
||
| public async getJoinDaoLlcInstructionIfNeeded( |
There was a problem hiding this comment.
I would make these separated functions.
hadJoinedDaoLlc and getJoinDaoLlcInstruction
Then you dont have to check if this the result of this function is undefined
keyvankhademi
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some stake accounts are not created through the createStakeAccount function.
Therefore they need to call joinDaoLlc when delegating/staking.