feat: display actual net apy #1993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cprussin
reviewed
Oct 3, 2024
| qualityRanking: number; | ||
| apyHistory: { date: Date; apy: number }[]; | ||
| delegationFee: bigint; | ||
| apyHistory: { date: Date; apy: number; selfApy: number }[]; |
There was a problem hiding this comment.
Hmm in my opinion it's better to pass the current stake account to the sdk when fetching the apy, rather than having all the raw data and calculating it all in the frontend, thoughts? never mind I see how you're threading this into calculateApy
keyvankhademi
approved these changes
Oct 3, 2024
cprussin
approved these changes
Oct 3, 2024
…o feat/display-actual-apy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the staking app so that APYs are display after delegation fees.
Publishers will still see the full apy in their self staking view, since that's what they get.