fix: lowest epoch calc #2018
Merged
fix: lowest epoch calc #2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
guibescos
commented
Oct 9, 2024
| lowestEpoch === undefined ? undefined : epochToDate(lowestEpoch + 52n), | ||
| instructions.lowestEpoch === undefined | ||
| ? undefined | ||
| : epochToDate(instructions.lowestEpoch + 53n), |
There was a problem hiding this comment.
I think the 52 was wrong and should instead be 53, if my math isn't wrong.
Comment on lines
696
to
701
| if ( | ||
| lowestEpoch === undefined || | ||
| position.activationEpoch < lowestEpoch | ||
| ) { | ||
| lowestEpoch = position.activationEpoch; | ||
| } |
There was a problem hiding this comment.
can we use bigintMax here?
There was a problem hiding this comment.
I guess we have to use bigintMin. It might be worth making it a funciton since it'll be used in 2 different places.
Comment on lines
773
to
+776
| return { | ||
| advanceDelegationRecordInstructions, | ||
| mergePositionsInstruction, | ||
| publishers, | ||
| lowestEpoch, |
There was a problem hiding this comment.
we have to refactor this function at some point, probably not worth doing rn.
keyvankhademi
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now lowest epoch calculation was wrong because it only took into account delegation records, but these don't exist if you have never claimed.
When the delegation record doesn't exist, you need to look at the activationEpoch of the positions to get a sense of the expiry date of the rewards.