feat(component-library): initialize component library #2042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cprussin is attempting to deploy a commit to the Pyth Network Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
cprussin
force-pushed
the
initialize-component-library
branch
from
e526ae6 to
2458067
Compare
cprussin
force-pushed
the
initialize-component-library
branch
from
2458067 to
bce8513
Compare
danimhr
reviewed
Oct 15, 2024
| const ButtonInner = (props: OwnProps) => ( | ||
| <> | ||
| {"beforeIcon" in props && <Icon icon={props.beforeIcon} />} | ||
| {"children" in props && props.children !== "" && ( |
There was a problem hiding this comment.
Out of curiosity, isn't it possible for a component to return null in some cases?
if (...) {
return null;
}
if (...) {
return null;
}
return <Text> Admin </Text>;
I think you are using the && pattern in the code, but I think it can happen. Not sure if there is any specific eslint rule for that or maybe I'm missing sth here.
There was a problem hiding this comment.
In this case no because the type of children is children?: string: https://github.com/pyth-network/pyth-crosschain/pull/2042/files#diff-4f427b4c6e5288a1739a1654ff79451ca88da6f7cb92a0fc95a866d82c27e9b9R11
cprussin
force-pushed
the
initialize-component-library
branch
from
bce8513 to
6747b65
Compare
cprussin
force-pushed
the
initialize-component-library
branch
from
6747b65 to
35f24d4
Compare
cprussin
force-pushed
the
initialize-component-library
branch
from
35f24d4 to
5c69ed6
Compare
cprussin
force-pushed
the
initialize-component-library
branch
from
5c69ed6 to
5b3e177
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.