feat(apps/benchmarks_keeper): init benchmarks_keeper #2047
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Riateche
reviewed
Oct 22, 2024
apps/benchmarks_keeper/src/lib.rs
Outdated
|
|
||
| // Process PriceUpdate events | ||
| let mut stream = sub.into_stream(); | ||
| while let Some(log) = stream.next().await { |
There was a problem hiding this comment.
We should probably have a reconnect on the error and a liveness check in case the streams gets stuck without producing new data.
apps/benchmarks_keeper/src/lib.rs
Outdated
|
|
||
| // Subscribe to PriceUpdate events | ||
| let filter = PriceUpdate::filter().address(config.contract_address); | ||
| let sub = provider.subscribe_logs(&filter).await?; |
There was a problem hiding this comment.
Does it only fetch new events? How do you plan to deal with events that were missed while the service was not running? I was thinking that maybe we should query old events (up to a certain age) and try to process them as well.
|
|
||
| #[derive(Debug, Serialize)] | ||
| pub struct PriceUpdateResults { | ||
| pub results: HashMap<String, PriceUpdateResult>, |
There was a problem hiding this comment.
"Result" name can be misleading in Rust context. I'd prefer something like PriceFeedValue or PriceFeedInfo.
cctdaniel
force-pushed
the
benchmarks-keeper
branch
from
e7d5843 to
950eb2e
Compare
cctdaniel
force-pushed
the
benchmarks-keeper
branch
from
950eb2e to
7bf5373
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.