feat(target_chains/ton): add parse_price_feed_updates #2099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
cctdaniel
commented
Nov 6, 2024
|
|
||
| () update_price_feeds(int msg_value, slice data) impure { | ||
| load_data(); | ||
| tuple parse_price_feeds_from_data(slice data) { |
There was a problem hiding this comment.
tuple is how we deal with arrays in func
OpenCoreCH
approved these changes
Nov 7, 2024
OpenCoreCH
reviewed
Nov 8, 2024
| load_data(); | ||
|
|
||
| ;; Load price_ids tuple | ||
| int price_ids_len = price_ids_slice~load_uint(8); |
There was a problem hiding this comment.
Should price_ids_len == 0 be supported? This will then be treated like a call from update_price_feeds within parse_price_feeds_from_data and everything will be included, meaning min_publish_time and max_publish_time are ignored.
ali-behjati
reviewed
Nov 8, 2024
cctdaniel
commented
Nov 11, 2024
| int i = price_feeds.tlen() - 1; | ||
| while (i >= 0) { | ||
| tuple price_feed = price_feeds.at(i); | ||
| int price_id = price_feed.at(0); |
There was a problem hiding this comment.
0 is price_id, 1 is price_feed_cell
ali-behjati
reviewed
Nov 11, 2024
ali-behjati
reviewed
Nov 11, 2024
ali-behjati
reviewed
Nov 11, 2024
ali-behjati
reviewed
Nov 11, 2024
Comment on lines
+243
to
+249
| if (price_ids_len == 0) { | ||
| ordered_feeds~udict_set(8, index, begin_cell() | ||
| .store_uint(price_id, 256) | ||
| .store_ref(price_feed_cell) | ||
| .end_cell().begin_parse()); | ||
| index += 1; | ||
| } else { |
There was a problem hiding this comment.
This is probably when having a top level if to return in this case makes the code cleaner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.