feat: add dynamic jito tips #2113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
guibescos
commented
Nov 12, 2024
| import { LAMPORTS_PER_SOL } from "@solana/web3.js"; | ||
|
|
||
| const HEALTH_CHECK_TIMEOUT_SECONDS = 60; | ||
| const MAX_JITO_TIP_LAMPORTS = LAMPORTS_PER_SOL / 100; |
There was a problem hiding this comment.
I think I'll make this configurable but didn't have time today
ali-behjati
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
LGTM. A few notes/questions below:
- what is the possibility that we use this and the transaction doesn't land? should we have mechanisms to use other percentiles?
- My worry is that we kind of end up in a worse situation. Maybe it's good to have min(max_fee, max(default_fee, dynamic_fee)) to kind of make sure we are at least never getting worse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.