feat(solana-receiver-cli): Add post-twap-update cmd to CLI, update TWAP data model & validations
#2180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, added post twap subcommand to CLI
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
tejasbadadare
changed the title
post-twap-update cmd to CLI, update TWAP data model & validationspost-twap-update cmd to CLI, update TWAP data model & validations
ali-behjati
reviewed
Dec 10, 2024
Collaborator
ali-behjati
left a comment
ali-behjati
left a comment
There was a problem hiding this comment.
I like the refactors. I left some comments which are mostly questions for me to understand your change before approving.
target_chains/solana/pyth_solana_receiver_sdk/src/price_update.rs
Outdated
Show resolved
Hide resolved
guibescos
reviewed
Dec 10, 2024
guibescos
reviewed
Dec 10, 2024
guibescos
reviewed
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR makes changes to the Solana receiver contract, the receiver SDK, and the receiver CLI.
Add
post-twap-updatecommand to the CLI. This is useful for users to test the update procedure, and to see an example of how to verify start & end data from Hermes via Wormhole and post it to the receiver contract.pyth-solana-receiver-cli --wormhole <WORMHOLE> post-twap-update --start-payload <START_PAYLOAD> --end-payload <END_PAYLOAD>Add extra validations to
calculate_twapas brought up in earlier code review.feed_idandexponentUpdate
TwapUpdatedata model to remove theverification_level&posted_slotfields.verification_levelfield is unnecessary because we don't support an "atomic" version of this instruction. It's required to verify VAAs before usingpost_twap_updateand the instruction will error if unverified VAAs are used. Therefore all TwapUpdates produced by the program can be assumed to be fully verified.posted_slotnot very useful since it's primarily used by price pushers to measure recency, which doesn't apply to our use case, unless we want to support some kind of scheduled/constantly pushed TWAP updates.Testing
Updated unit tests for
solana_receiver_sdk. The CLI doesn't have a test suite.