Skip to content

feat(insights): improve some minor table search UX items #2218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2024
Merged

feat(insights): improve some minor table search UX items #2218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions apps/insights/src/components/PriceFeed/publishers-card.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import { useFilter, useCollator } from "react-aria";
import styles from "./publishers-card.module.scss";
import { useQueryParamFilterPagination } from "../../use-query-param-filter-pagination";
import { FormattedNumber } from "../FormattedNumber";
import { NoResults } from "../NoResults";
import { PublisherTag } from "../PublisherTag";
import rootStyles from "../Root/index.module.scss";
import { Score } from "../Score";
Expand Down Expand Up @@ -284,7 +285,8 @@ const PriceComponentsCardContents = ({
</Switch>
<SearchInput
size="sm"
width={40}
width={60}
placeholder="Publisher key or name"
{...(props.isLoading
? { isPending: true, isDisabled: true }
: {
Expand Down Expand Up @@ -334,35 +336,35 @@ const PriceComponentsCardContents = ({
id: "uptimeScore",
name: "UPTIME SCORE",
alignment: "center",
width: 40,
width: 35,
allowsSorting: true,
},
{
id: "deviationScore",
name: "DEVIATION SCORE",
alignment: "center",
width: 40,
width: 35,
allowsSorting: true,
},
{
id: "deviationPenalty",
name: "DEVIATION PENALTY",
alignment: "center",
width: 40,
width: 35,
allowsSorting: true,
},
{
id: "stalledScore",
name: "STALLED SCORE",
alignment: "center",
width: 40,
width: 35,
allowsSorting: true,
},
{
id: "stalledPenalty",
name: "STALLED PENALTY",
alignment: "center",
width: 40,
width: 35,
allowsSorting: true,
},
]}
Expand All @@ -372,6 +374,14 @@ const PriceComponentsCardContents = ({
rows: props.rows,
sortDescriptor: props.sortDescriptor,
onSortChange: props.onSortChange,
renderEmptyState: () => (
<NoResults
query={props.search}
onClearSearch={() => {
props.onSearchChange("");
}}
/>
),
})}
/>
</Card>
Expand Down
22 changes: 18 additions & 4 deletions apps/insights/src/components/PriceFeeds/coming-soon-list.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import { type ReactNode, useMemo, useState } from "react";
import { useCollator, useFilter } from "react-aria";

import styles from "./coming-soon-list.module.scss";
import { NoResults } from "../NoResults";
import { PriceFeedTag } from "../PriceFeedTag";

type Props = {
Expand Down Expand Up @@ -78,9 +79,10 @@ export const ComingSoonList = ({ comingSoonFeeds }: Props) => {
<div className={styles.searchBar}>
<SearchInput
size="sm"
defaultValue={search}
value={search}
onChange={setSearch}
width={40}
width={50}
placeholder="Feed symbol"
/>
<Select
optionGroups={[
Expand All @@ -104,15 +106,27 @@ export const ComingSoonList = ({ comingSoonFeeds }: Props) => {
stickyHeader
label="Coming Soon"
className={styles.priceFeeds ?? ""}
renderEmptyState={() => (
<NoResults
query={search}
onClearSearch={() => {
setSearch("");
}}
/>
)}
columns={[
{
id: "priceFeedName",
name: "PRICE FEED",
isRowHeader: true,
fill: true,
alignment: "left",
},
{ id: "assetClass", name: "ASSET CLASS", alignment: "right" },
{
id: "assetClass",
name: "ASSET CLASS",
alignment: "right",
width: 40,
},
]}
rows={rows}
/>
Expand Down
3 changes: 2 additions & 1 deletion apps/insights/src/components/PriceFeeds/price-feeds-card.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,8 @@ const PriceFeedsCardContents = ({ id, ...props }: PriceFeedsCardContents) => (
/>
<SearchInput
size="sm"
width={40}
width={50}
placeholder="Feed symbol"
{...(props.isLoading
? { isPending: true, isDisabled: true }
: {
Expand Down
11 changes: 5 additions & 6 deletions apps/insights/src/components/Publisher/performance.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export const Performance = async ({ params }: Props) => {
{
id: "ranking",
name: "RANKING",
width: 30,
width: 25,
},
{
id: "name",
Expand All @@ -63,13 +63,13 @@ export const Performance = async ({ params }: Props) => {
id: "activeFeeds",
name: "ACTIVE FEEDS",
alignment: "center",
width: 40,
width: 30,
},
{
id: "inactiveFeeds",
name: "INACTIVE FEEDS",
alignment: "center",
width: 45,
width: 30,
},
{
id: "medianScore",
Expand Down Expand Up @@ -148,20 +148,19 @@ const feedColumns = [
id: "score" as const,
name: "SCORE",
alignment: "left" as const,
width: 40,
width: PUBLISHER_SCORE_WIDTH,
},
{
id: "asset" as const,
name: "ASSET",
isRowHeader: true,
alignment: "left" as const,
fill: true,
},
{
id: "assetClass" as const,
name: "ASSET CLASS",
alignment: "right" as const,
width: 50,
width: 40,
},
];

Expand Down
22 changes: 16 additions & 6 deletions apps/insights/src/components/Publisher/price-feeds-card.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import { useFilter, useCollator } from "react-aria";

import { useQueryParamFilterPagination } from "../../use-query-param-filter-pagination";
import { FormattedNumber } from "../FormattedNumber";
import { NoResults } from "../NoResults";
import { PriceFeedTag } from "../PriceFeedTag";
import rootStyles from "../Root/index.module.scss";
import { Score } from "../Score";
Expand Down Expand Up @@ -222,7 +223,8 @@ const PriceComponentsCardContents = ({
toolbar={
<SearchInput
size="sm"
width={40}
width={60}
placeholder="Feed symbol"
{...(props.isLoading
? { isPending: true, isDisabled: true }
: {
Expand Down Expand Up @@ -271,35 +273,35 @@ const PriceComponentsCardContents = ({
id: "uptimeScore",
name: "UPTIME SCORE",
alignment: "center",
width: 40,
width: 35,
allowsSorting: true,
},
{
id: "deviationScore",
name: "DEVIATION SCORE",
alignment: "center",
width: 40,
width: 35,
allowsSorting: true,
},
{
id: "deviationPenalty",
name: "DEVIATION PENALTY",
alignment: "center",
width: 40,
width: 35,
allowsSorting: true,
},
{
id: "stalledScore",
name: "STALLED SCORE",
alignment: "center",
width: 40,
width: 35,
allowsSorting: true,
},
{
id: "stalledPenalty",
name: "STALLED PENALTY",
alignment: "center",
width: 40,
width: 35,
allowsSorting: true,
},
]}
Expand All @@ -309,6 +311,14 @@ const PriceComponentsCardContents = ({
rows: props.rows,
sortDescriptor: props.sortDescriptor,
onSortChange: props.onSortChange,
renderEmptyState: () => (
<NoResults
query={props.search}
onClearSearch={() => {
props.onSearchChange("");
}}
/>
),
})}
/>
</Card>
Expand Down
9 changes: 5 additions & 4 deletions apps/insights/src/components/Publishers/publishers-card.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,8 @@ const PublishersCardContents = ({
toolbar={
<SearchInput
size="sm"
width={40}
width={60}
placeholder="Publisher key or name"
{...(props.isLoading
? { isPending: true, isDisabled: true }
: {
Expand Down Expand Up @@ -226,7 +227,7 @@ const PublishersCardContents = ({
{
id: "ranking",
name: "RANKING",
width: 30,
width: 25,
loadingSkeleton: <Ranking isLoading />,
allowsSorting: true,
},
Expand All @@ -242,14 +243,14 @@ const PublishersCardContents = ({
id: "activeFeeds",
name: "ACTIVE FEEDS",
alignment: "center",
width: 40,
width: 30,
allowsSorting: true,
},
{
id: "inactiveFeeds",
name: "INACTIVE FEEDS",
alignment: "center",
width: 45,
width: 30,
allowsSorting: true,
},
{
Expand Down
4 changes: 3 additions & 1 deletion packages/component-library/src/SearchInput/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ type Props = ComponentProps<typeof SearchField> & {
size?: (typeof SIZES)[number] | undefined;
width: number;
isPending?: boolean | undefined;
placeholder?: string;
};

export const SearchInput = ({
Expand All @@ -26,6 +27,7 @@ export const SearchInput = ({
width,
className,
isPending,
placeholder = "Search",
...props
}: Props) => (
<SearchField
Expand All @@ -36,7 +38,7 @@ export const SearchInput = ({
{...(isPending && { "data-pending": "" })}
{...props}
>
<Input className={styles.input ?? ""} placeholder="Search" />
<Input className={styles.input ?? ""} placeholder={placeholder} />
<MagnifyingGlass className={styles.searchIcon} />
<CircleNotch className={styles.loadingIcon} />
<Button className={styles.clearButton ?? ""}>
Expand Down
2 changes: 1 addition & 1 deletion packages/component-library/src/Table/index.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
white-space: nowrap;
border: 0;
outline: theme.spacing(0.5) solid transparent;
width: calc(theme.spacing(1) * var(--width));
width: calc((theme.spacing(1) * var(--width)) + theme.spacing(8));
outline-offset: -#{theme.spacing(0.5)};
background-color: theme.color("background", "primary");
transition: outline-color 100ms linear;
Expand Down
Loading