feat(fortuna): Dynamically increase gas limit for a transaction on failure #2238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
jayantk
commented
Jan 10, 2025
| chain_eth_config.gas_limit, | ||
| // NOTE: we adjust fees based on the maximum gas that the keeper will submit a callback with. | ||
| // This number is *larger* than the configured gas limit, as we pad gas on transaction submission for reliability. | ||
| (chain_eth_config.gas_limit * DEFAULT_GAS_ESTIMATE_MULTIPLIER_PCT) / 100, |
There was a problem hiding this comment.
We were previously multiplying by 5/4 in the function that sends the TX, but we weren't accounting for that when setting the tx fee.
jayantk
commented
Jan 10, 2025
| } | ||
|
|
||
| fn default_backoff_gas_multiplier_pct() -> u64 { | ||
| 100 |
There was a problem hiding this comment.
we may want to set this to some reasonable % in the future, but let's see how the abstract thing goes first.
m30m
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds auto-scaling for the transaction gasLimit parameter when the callback fails. There seems to be an issue on abstract-testnet where some transactions hit this limit for unknown reasons.
I also drive-by fixed an error with the fee calculation.