Skip to content

feat: Remove Real Time Channel #2304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 29, 2025
Merged

feat: Remove Real Time Channel #2304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4d3928c
Remove real time channel
darunrs Jan 28, 2025
c3bba73
Update to new version
darunrs Jan 28, 2025
cf36dbd
Change fixed rate to id 1 and retain real time parsing to fixed rate
darunrs Jan 28, 2025
55f8695
Serialize min fixed rate to real time
darunrs Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lazer/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lazer/sdk/rust/protocol/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "pyth-lazer-protocol"
version = "0.3.3"
version = "0.4.0"
edition = "2021"
description = "Pyth Lazer SDK - protocol types."
license = "Apache-2.0"
Expand Down
11 changes: 5 additions & 6 deletions lazer/sdk/rust/protocol/src/router.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,6 @@ pub enum JsonBinaryEncoding {

#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash, PartialOrd, Ord)]
pub enum Channel {
RealTime,
FixedRate(FixedRate),
}

Expand All @@ -173,8 +172,10 @@ impl Serialize for Channel {
S: serde::Serializer,
{
match self {
Channel::RealTime => serializer.serialize_str("real_time"),
Channel::FixedRate(fixed_rate) => {
if *fixed_rate == FixedRate::MIN {
return serializer.serialize_str("real_time");
}
serializer.serialize_str(&format!("fixed_rate@{}ms", fixed_rate.value_ms()))
}
}
Expand All @@ -184,16 +185,14 @@ impl Serialize for Channel {
mod channel_ids {
use super::ChannelId;

pub const REAL_TIME: ChannelId = ChannelId(1);
pub const FIXED_RATE_1: ChannelId = ChannelId(1);
pub const FIXED_RATE_50: ChannelId = ChannelId(2);
pub const FIXED_RATE_200: ChannelId = ChannelId(3);
pub const FIXED_RATE_1: ChannelId = ChannelId(4);
}

impl Channel {
pub fn id(&self) -> ChannelId {
match self {
Channel::RealTime => channel_ids::REAL_TIME,
Channel::FixedRate(fixed_rate) => match fixed_rate.value_ms() {
1 => channel_ids::FIXED_RATE_1,
50 => channel_ids::FIXED_RATE_50,
Expand All @@ -213,7 +212,7 @@ fn id_supports_all_fixed_rates() {

fn parse_channel(value: &str) -> Option<Channel> {
if value == "real_time" {
Some(Channel::RealTime)
Some(Channel::FixedRate(FixedRate::MIN))
} else if let Some(rest) = value.strip_prefix("fixed_rate@") {
let ms_value = rest.strip_suffix("ms")?;
Some(Channel::FixedRate(FixedRate::from_ms(
Expand Down
Loading