refactor(governance/xc_admin): add more logs on relayer #2324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the relayer fails for whatever reason it is hard to debug what is going on. This change adds more logs to see the details of the proposals which is quite helpful in debugging the issues.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
ali-behjati
commented
Feb 4, 2025
| ComputeBudgetProgram.setComputeUnitLimit({ units: 1000000 }), | ||
| ]) | ||
| .rpc({ skipPreflight: true }); | ||
| .rpc({ skipPreflight: false }); |
There was a problem hiding this comment.
I think we get better logs with simulation. Why was it true before?
There was a problem hiding this comment.
I normally got the logs from explorer, but it might be nicer to get them from Grafana (like this would enable)
ali-behjati
commented
Feb 4, 2025
| provider.wallet.publicKey, | ||
| Buffer.from(response.vaaBytes, "base64"), | ||
| { commitment: COMMITMENT } | ||
| { commitment: COMMITMENT, maxRetries: 10 } |
There was a problem hiding this comment.
I couldn't see what the default is. It was often failing at this step.
There was a problem hiding this comment.
meeeh, people in Solana recommend 0 retries at this level
https://github.com/rpcpool/optimized-txs-examples/blob/main/selfSolTransfer.mjs#L116
instead if you'd like to retry you should put postVaaSolana inside a for loop
ali-behjati
commented
Feb 4, 2025
| Connection, | ||
| Keypair, | ||
| PublicKey, | ||
| SystemProgram, |
guibescos
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the relayer fails for whatever reason it is hard to debug what is going on. This change adds more logs to see the details of the proposals which is quite helpful in debugging the issues.