Skip to content

Conversation

@devin-ai-integration
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Feb 7, 2025

Add docker build steps to CI workflows for PRs that modify relevant files.

Each workflow will now:

  • Build (but not publish) docker images on PRs that modify associated files
  • Keep existing publish behavior for main/tags
  • Use path filters to only trigger on relevant changes
  • Maintain consistent branch protection patterns

All workflows have been updated:

  • price-pusher: apps/price_pusher/** and Dockerfile.node
  • hermes: apps/hermes/server/**
  • xc-admin-frontend: governance/xc_admin/**
  • fortuna: apps/fortuna/**

Link to Devin run: https://app.devin.ai/sessions/3287e5a43b7b4046bd9ac6785d12cbc0
Requested by: Jayant

@vercel
Copy link

vercel bot commented Feb 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 7:34pm
proposals ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 7:34pm
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 7:34pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
component-library ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 7:34pm
entropy-debugger ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 7:34pm
insights ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 7:34pm

@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

branches: [main]
paths: [governance/xc_admin/**]
pull_request:
paths: [governance/xc_admin/**]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the push below is already gated on the main branch

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, I was just checking on that

@devin-ai-integration devin-ai-integration bot force-pushed the devin/1738954286-add-pr-docker-builds branch from 1855480 to 5ca16da Compare February 7, 2025 19:17
Copy link
Collaborator

@cprussin cprussin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edit: never mind

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we consider renaming these workflows since they won't necessarily push now? most of the invocations will be just builds in PRs

@jayantk jayantk merged commit 479b596 into main Feb 7, 2025
7 of 8 checks passed
@jayantk jayantk deleted the devin/1738954286-add-pr-docker-builds branch February 7, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants