feat(pulse): add getFirstActiveRequests function to retrieve active requests #2371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
…ts and update related comments
cctdaniel
changed the title
ali-behjati
approved these changes
Feb 12, 2025
Comment on lines
+934
to
+953
| function testRequestScenarios( | ||
| bytes32[] memory priceIds, | ||
| bytes[] memory updateData | ||
| ) private { | ||
| // Test 1: Request more than available | ||
| checkMoreThanAvailable(); | ||
|
|
||
| // Test 2: Request exact number | ||
| checkExactNumber(); | ||
|
|
||
| // Test 3: Request fewer than available | ||
| checkFewerThanAvailable(); | ||
|
|
||
| // Test 4: Request zero | ||
| checkZeroRequest(); | ||
|
|
||
| // Test 5: Clear all and check empty | ||
| clearAllRequests(updateData, priceIds); | ||
| checkEmptyState(); | ||
| } |
There was a problem hiding this comment.
not a strong opinion but if these are different tests maybe they can be different tests?
ali-behjati
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.