Skip to content

fix(insights): don't blow up on invalid featured symbol #2411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2025
Merged

fix(insights): don't blow up on invalid featured symbol #2411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 3 additions & 15 deletions apps/insights/src/components/PriceFeeds/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,21 +210,9 @@ const filterFeeds = <T extends { symbol: string }>(
feeds: T[],
symbols: string[],
): T[] =>
symbols.map((symbol) => {
const feed = feeds.find((feed) => feed.symbol === symbol);
if (feed) {
return feed;
} else {
throw new NoSuchFeedError(symbol);
}
});
symbols
.map((symbol) => feeds.find((feed) => feed.symbol === symbol))
.filter((feed) => feed !== undefined);

const isActive = (feed: { price: { minPublishers: number } }) =>
feed.price.minPublishers <= 50;

class NoSuchFeedError extends Error {
constructor(symbol: string) {
super(`No feed exists named ${symbol}`);
this.name = "NoSuchFeedError";
}
}
2 changes: 1 addition & 1 deletion apps/insights/src/static-data/price-feeds.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@ export const priceFeeds = {
"Commodities.WTI1M",
"Crypto.1INCH/USD",
],
featuredComingSoon: ["Crypto.ION/USD", "Equity.NL.BCOIN/USD"],
featuredComingSoon: ["Rates.US1Y"],
};
Loading