feat(lazer): add new formats to protocol #2414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
Comment on lines
-18
to
+80
| writer.write_u32::<BE>(EVM_FORMAT_MAGIC)?; | ||
| writer.write_u32::<LE>(EVM_FORMAT_MAGIC)?; |
There was a problem hiding this comment.
isn't this a breaking change? How does the current contracts in EVM that expect BE work with this?
There was a problem hiding this comment.
It's not a breaking change because I changed the constant value.
keyvankhademi
approved these changes
Feb 26, 2025
lazer/sdk/rust/client/Cargo.toml
Outdated
|
|
||
| [dependencies] | ||
| pyth-lazer-protocol = "0.5.0" | ||
| pyth-lazer-protocol = { path = "../protocol", version = "0.5.0" } |
There was a problem hiding this comment.
doesn't this break the publishing to cargo?
There was a problem hiding this comment.
No, cargo is smart enough to remove paths on publish.
|
I think you should increase the protocol version too. |
|
Bumped protocol version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Messageenum for ser/deserializing any message type.BinaryWsUpdatefor ser/deserializing binary WS updates.I wanted to deprecate
parsedin router API and replace it withformats: ["json"]but unfortunatelyparsedis true by default to we can't easily deprecate it. We can remove it when we do a breaking change and go for a/v2/..endpoint.Tested WS client against a prod router to verify no breaking changes. Tested in tilt for new formats.