fix(lazer): address evm contract audit #2415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ali-behjati
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.1. Signature malleability
Fixed by using OpenZeppelin's ECDSA library instead of the raw ecrecover function.
3.2. Improper initialization within the UUPS pattern
Fixed by adding
_disableInitializers()to the constructor. Updated tests to set up a proxy.3.3. Performing duplicate checks within the same range of update length
It's not possible to remove the
if update.length < 71check because that would add a possibility of out-of-bounds access at the next line (update[69:71]).3.4. Inclusion of unnecessary migrate function
Removed
migrate().3.5. Remove unused code lines
Removed unused import.