feat(price_pusher): add gas-price override option for EVM price pusher #2419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=80&v=4){kind=small}
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
ali-behjati
approved these changes
Feb 26, 2025
cprussin
reviewed
Feb 26, 2025
apps/price_pusher/src/evm/evm.ts
Outdated
| Number(await this.client.getGasPrice()); | ||
| this.gasPrice !== undefined | ||
| ? this.gasPrice | ||
| : Number(await this.customGasStation?.getCustomGasPrice()) || |
There was a problem hiding this comment.
Using || to coalesce zeros is generally considered bad practice since it's surprising and unintuitive.
If I understand the intent of this code correctly, I think this would be better written as:
let gasPrice = this.gasPrice ?? Number(await (this.customGasStation?.getCustomGasPrice() ?? this.client.getGasPrice()));
Co-Authored-By: Ali Behjati <[email protected]>
Co-Authored-By: Ali Behjati <[email protected]>
Co-Authored-By: Ali Behjati <[email protected]>
ali-behjati
force-pushed
the
devin/1740577182-add-gas-price-override
branch
from
3149076 to
5738b2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add gas-price override option for EVM price pusher
Summary
This PR adds an optional
gas-priceargument to the EVM price pusher that allows overriding the gas price received from the RPC viaawait this.client.getGasPrice().Changes
gas-pricecommand line option to the EVM price pusher commandEvmPricePusherconstructor to accept the new parameterLink to Devin run
https://app.devin.ai/sessions/f9167dfbae7840baae3732610d30d08f
Requested by
user