fix: add libusb to github action runners that do pnpm install #2421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
cprussin
force-pushed
the
cprussin/add-libusb-to-gha
branch
from
5fe8233 to
27e95a6
Compare
cprussin
force-pushed
the
cprussin/add-libusb-to-gha
branch
from
27e95a6 to
22bfeb6
Compare
ali-behjati
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add libusb to github action runners (where
pnpm installis needed)Rationale
One of our node dependencies,
node-hid, is a native extension which depends onlibusb. In the past this dependency has distributed precompiled binaries so it wasn't necessary to havelibusbbecause usually the compile wouldn't be required as part of the install. However, it seems something has changed and those precompiled binaries are no longer being found reliably, and so we need to make sure we havelibusbavailable wherever we do apnpm installin case a build is needed.How has this been tested?
N/A, if CI succeeds then it works.