feat(target_chains/sui): add iota network #2428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
ali-behjati
force-pushed
the
chore/sui/add-iota
branch
from
d268170 to
facfc85
Compare
ali-behjati
force-pushed
the
chore/sui/add-iota
branch
from
facfc85 to
2e4e0af
Compare
math lib is deprecated.
ali-behjati
force-pushed
the
chore/sui/add-iota
branch
from
2e4e0af to
817c7d4
Compare
m30m
reviewed
Mar 7, 2025
| import { IOTA_CLOCK_OBJECT_ID } from "@iota/iota-sdk/utils"; | ||
| import { Ed25519Keypair } from "@iota/iota-sdk/keypairs/ed25519"; | ||
| import { Transaction } from "@iota/iota-sdk/transactions"; | ||
| import { uint8ArrayToBCS } from "@certusone/wormhole-sdk/lib/cjs/sui"; |
There was a problem hiding this comment.
can't we use something from "@iota/iota-sdk/bcs"
There was a problem hiding this comment.
No unfortunately they don't have it (same for SUI). It's not a super complicated function though.
m30m
approved these changes
Mar 7, 2025
ali-behjati
force-pushed
the
chore/sui/add-iota
branch
from
56d6169 to
21f2bbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change adds support for IOTA network which is a SUI based network. Unfortunately as the internals are all renamed from SUI to IOTA nothing in SUI ecosystem works (compiler/rpc/sdk...) and I needed to create new packages for IOTA.
Since this change has many mechanical changes, I recommend you review it commit-by-commit. The wormhole vendor-in and JS package creation are the two mechanical commits that contain only copy and paste.
During the process I fixed some issues within Sui (deprecated tx.pure usage) to make things work. There might be some parts that I haven't touched and are not still working but I tried to pass everywhere to make sure it works.
Rationale
I tried to avoid creation of new packages but as downstream users need some of these I decided to do so.
How has this been tested?
I used the new packages to deploy the new contract and updated price feeds in those contracts.