Skip to content

Conversation

morancj
Copy link
Contributor

@morancj morancj commented Feb 27, 2025

Summary

CODEOWNERS for GH workflows, CODEOWNERS itself

Rationale

Reduce the chances of PRs to use the medium or large runners racking up our spend

How has this been tested?

Only via the GH verification:

This CODEOWNERS file is valid.

I don't believe we can fully test until it's merged.

@morancj morancj requested a review from cprussin February 27, 2025 16:33
@vercel
Copy link

vercel bot commented Feb 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 4:33pm
proposals ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 4:33pm
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 4:33pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
component-library ⬜️ Ignored (Inspect) Feb 27, 2025 4:33pm
entropy-debugger ⬜️ Ignored (Inspect) Feb 27, 2025 4:33pm
insights ⬜️ Ignored (Inspect) Feb 27, 2025 4:33pm

Copy link
Collaborator

@cprussin cprussin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to change the title of this PR before merging since it's not actually restricting access, just adding automatic reviewers, and someone seeing the message "restrict access" in the commit log may be confused :)

@morancj
Copy link
Contributor Author

morancj commented Feb 27, 2025

You may want to change the title of this PR before merging since it's not actually restricting access, just adding automatic reviewers, and someone seeing the message "restrict access" in the commit log may be confused :)

doh, sorry, thanks!

@morancj morancj changed the title chore(ci): restrict access to .github and CODEOWNERS chore(ci): update reviewers for /.github/ and CODEOWNERS Feb 27, 2025
@morancj morancj force-pushed the morancj/ci-CODEOWNERS branch from ac0b95b to a03d13c Compare February 28, 2025 15:12
@morancj morancj merged commit d85b045 into main Feb 28, 2025
1 check passed
@morancj morancj deleted the morancj/ci-CODEOWNERS branch February 28, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants