Skip to content

Conversation

@devin-ai-integration
Copy link
Contributor

Add a metric to fortuna to track the accrued pyth fees for each chain by calling contract.get_accrued_pyth_fees() and add a function in track.rs to track these global metrics of the contract.

Link to Devin run: https://app.devin.ai/sessions/9b235bf52dca45faa9dc8f591ee9b8b6
Requested by: User

@vercel
Copy link

vercel bot commented Mar 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2025 3:36pm
proposals ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2025 3:36pm
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2025 3:36pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
component-library ⬜️ Ignored (Inspect) Visit Preview Mar 6, 2025 3:36pm
entropy-debugger ⬜️ Ignored (Inspect) Visit Preview Mar 6, 2025 3:36pm
insights ⬜️ Ignored (Inspect) Visit Preview Mar 6, 2025 3:36pm

@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

pub final_gas_multiplier: Family<AccountLabel, Histogram>,
pub final_fee_multiplier: Family<AccountLabel, Histogram>,
pub gas_price_estimate: Family<AccountLabel, Gauge<f64, AtomicU64>>,
pub accrued_pyth_fees: Family<AccountLabel, Gauge<f64, AtomicU64>>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the key for this Family should be chain id not AccountLabel

Co-Authored-By: Jayant Krishnamurthy <[email protected]>
@devin-ai-integration
Copy link
Contributor Author

I've addressed this comment by creating a new ChainIdLabel struct that implements EncodeLabelSet for ChainId, and updated the code to use this struct instead of AccountLabel.

@devin-ai-integration
Copy link
Contributor Author

I've addressed this comment by creating a new ChainIdLabel struct that implements EncodeLabelSet for ChainId, and updated the code to use this struct instead of AccountLabel directly. This change is included in the commit 8c78ac4.

@jayantk jayantk merged commit 5d2ef61 into main Mar 6, 2025
10 checks passed
@jayantk jayantk deleted the devin/1741273325-add-metric-track-pyth-fees branch March 6, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants