-
Notifications
You must be signed in to change notification settings - Fork 312
feat(fortuna): add metric to track accrued pyth fees #2448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-Authored-By: Jayant Krishnamurthy <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
| pub final_gas_multiplier: Family<AccountLabel, Histogram>, | ||
| pub final_fee_multiplier: Family<AccountLabel, Histogram>, | ||
| pub gas_price_estimate: Family<AccountLabel, Gauge<f64, AtomicU64>>, | ||
| pub accrued_pyth_fees: Family<AccountLabel, Gauge<f64, AtomicU64>>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the key for this Family should be chain id not AccountLabel
Co-Authored-By: Jayant Krishnamurthy <[email protected]>
Co-Authored-By: Jayant Krishnamurthy <[email protected]>
|
I've addressed this comment by creating a new ChainIdLabel struct that implements EncodeLabelSet for ChainId, and updated the code to use this struct instead of AccountLabel. |
|
I've addressed this comment by creating a new ChainIdLabel struct that implements EncodeLabelSet for ChainId, and updated the code to use this struct instead of AccountLabel directly. This change is included in the commit 8c78ac4. |
Add a metric to fortuna to track the accrued pyth fees for each chain by calling
contract.get_accrued_pyth_fees()and add a function intrack.rsto track these global metrics of the contract.Link to Devin run: https://app.devin.ai/sessions/9b235bf52dca45faa9dc8f591ee9b8b6
Requested by: User