feat(pulse): Pulse Gas Benchmark #2467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 6 Skipped Deployments
|
ali-behjati
approved these changes
Mar 11, 2025
| // Subtract this amount from the gas benchmarks to estimate the true usafe of the pulse flow. | ||
| function testDataMocking() public { | ||
| uint64 timestamp = SafeCast.toUint64(block.timestamp); | ||
| createPriceIds(); |
There was a problem hiding this comment.
Optimisations might ignore the memory cost of having this.
cctdaniel
reviewed
Mar 12, 2025
| } | ||
|
|
||
| // Estimate how much gas is used by all of the data mocking functionality in the other gas benchmarks. | ||
| // Subtract this amount from the gas benchmarks to estimate the true usafe of the pulse flow. |
cctdaniel
reviewed
Mar 12, 2025
| } | ||
| } | ||
|
|
||
| contract VoidPulseConsumer is IPulseConsumer { |
There was a problem hiding this comment.
maybe add some documentation here for e.g. this consumer has an empty callback implementation to measure the baseline gas costs
cctdaniel
reviewed
Mar 12, 2025
| uint64 timestamp = SafeCast.toUint64(block.timestamp); | ||
| bytes32[] memory priceIds = createPriceIds(); | ||
|
|
||
| uint128 callbackGasLimit = 100000; |
There was a problem hiding this comment.
why are we not using the same value used in PulseTestUtils.t.sol CALLBACK_GAS_LIMIT?
if no specific reason then maybe we can just use the constant declared there so as to standardize
cctdaniel
reviewed
Mar 12, 2025
There was a problem hiding this comment.
should we also have more tests such as
testMaxPriceFeeds - tests the performance impact of processing maximum number of price feedstestMultipleSequentialRequests - tests the performance impact of the request clearing and sequence number updatestestFailingCallback - tests the error handling path in the executeCallback function
cctdaniel
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I'm a little concerned that the big data structures in pulse are going to use a lot of gas, so here's a gas benchmark that we can use to measure. I refactored out some of the test utilities into a separate utils class so that I could reuse them in the gas benchmark. You run this benchmark per the existing instructions in the README.
How has this been tested?