chore: rebuild pnpm lockfile #2489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cprussin
commented
Mar 17, 2025
| const c = chains.find(({ chain_name }) => chain_name === "osmosis"); | ||
| if (c === undefined) | ||
| throw new Error("Could not find Osmosis in chain registry"); | ||
| this.chain = c; |
There was a problem hiding this comment.
This whole block was warning because chain is a private variable that's never consumed, meaning none of this should be needed. Please someone who knows this package better -- please help take a look and make sure there's nothing hacky that's breaking the static analysis here and actually uses this in some unexpected way...
cprussin
force-pushed
the
cprussin/rebuild-pnpm-lock
branch
from
f6adbce to
91a7a23
Compare
ali-behjati
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR rebuilds the
pnpm-lock.yamlfile. The steps to do this are:git clean -fdx(reset the git repo to a fresh state)rm pnpm-lock.yamlpnpm ipnpm dedupeThis PR also includes some fixes for some packages whose dependencies moved without major version bumps, but which in fact included breaking changes.
Rationale
It's important to rebuild the pnpm lockfile occasionally for a few reasons:
package.jsonfilesWe haven't been able to do this for a while due to a myriad of dependency issues, but with #2488 , those dependency issues were resolved and we can now do this.
How has this been tested?